Add EventProcessor SystemParam that gives mutable access to events#8051
Closed
tim-blackbird wants to merge 3 commits intobevyengine:mainfrom
Closed
Add EventProcessor SystemParam that gives mutable access to events#8051tim-blackbird wants to merge 3 commits intobevyengine:mainfrom
EventProcessor SystemParam that gives mutable access to events#8051tim-blackbird wants to merge 3 commits intobevyengine:mainfrom
Conversation
tim-blackbird
changed the title
EventProcessor SystemParam for modifying eventsEventProcessor SystemParam that gives mutable access to events
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Sep 29, 2023
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I like it! I think we should link to this (and its siblings) from the Events docs somehow, but I won't block on it.
Contributor
|
This is available as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Allow events to be modified 'in-flight'.
Solution
Add a new
EventProcessorSystemParamthat containsResMut<Events<E>>that gives an iterator over mutable references to the events.New code is 95% identical to the existing immutable code, but I'm not sure if a macro is warranted to reduce code duplication.
Changelog
EventProcessoriter_mutanditer_mut_with_idtoManualEventReader