Fix size of clipped text glyphs.#8197
Merged
cart merged 2 commits intobevyengine:mainfrom Apr 5, 2023
Merged
Conversation
…ansform extracted from the `extract_text_nodes` had a scaling on it that wasn't accounted for. Fixed this by removing the scaling from the transform and multiplying the size of the glyph's by the scale factor.
james7132
added
C-Bug
Contributor
|
Tested with new example from #8198, moving text clip (bottom-left) is working fine with this PR. 👌 8197-fixed.mp4 |
cart
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Text glyphs that were clipped were not sized correctly because the transform extracted by
extract_text_uinodeshad a scaling on it that wasn't accounted for.fixes #8167
Solution
Remove the scaling from the transform and multiply the size of the glyphs by the inverse of the scale factor.