Move ShaderCache shader defs into a resource#8202
Closed
ProfLander wants to merge 1 commit intobevyengine:mainfrom
Closed
Move ShaderCache shader defs into a resource#8202ProfLander wants to merge 1 commit intobevyengine:mainfrom
ProfLander wants to merge 1 commit intobevyengine:mainfrom
Conversation
14c5663 to
f1b18fa
Compare
tychedelia
approved these changes
Aug 16, 2024
Member
tychedelia
left a comment
There was a problem hiding this comment.
This helps clean up the ShaderCache code itself and I like having these in a default location. The disadvantage now is that users of pipeline specialization don't get these "for free." Overall seems like a good change since it helps prevent an annoying error, but I'd like more documentation somewhere about what our "base" shader defs are for users who might want to use them for consistency.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
NO_STORAGE_BUFFERS_SUPPORT,NO_ARRAY_TEXTURES_SUPPORTandSIXTEEN_BYTE_ALIGNMENTare injected byShaderCache::get, which occurs after pipeline specialization, and therefore afterMaterialorMaterial2dget the chance to inspect or mutate them in their respectivespecializefunctions.Fixes
Material::specializeis provided an incomplete set of engine-sourced shader definitions #8190Solution
BaseShaderDefsnewtype resource, and have consuming pipelines retrieve it in theirFromWorldimplementation for use during specialization.Changelog
ShaderCacheBaseShaderDefsresource implemented to hold affected defs, inserted into the render world byRenderPluginBaseShaderDefsinFromWorld, and use it in lieu of constructing an empty defs vec inspecialize:Migration Guide
This is a non-breaking change, but future pipeline implementors should be made aware that the defs in question should be manually sourced from the ECS.