Merged
Conversation
james7132
added
A-ECS
danchia
approved these changes
Mar 30, 2023
Contributor
danchia
left a comment
danchia
left a comment
There was a problem hiding this comment.
I am not a criterion expert but this looks good to me. had a small suggestion.
joseph-gio
approved these changes
Mar 30, 2023
Member
joseph-gio
left a comment
joseph-gio
left a comment
There was a problem hiding this comment.
LGTM, got a couple of suggestions.
james7132
added
the
S-Ready-For-Final-Review
Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com>
danchia
approved these changes
Mar 30, 2023
Member
|
would it be interesting to have benches for events of other size? |
Member
Author
|
Split the benchmarks to support events of size 4, 16, and 512 bytes. |
mockersf
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix #7731. Add basic Event sending and iteration benchmarks to bevy_ecs's benchmark suite.
Solution
Add said benchmarks scaling from 100 to 50,000 events.
Not sure if I want to include a randomization of the events going in, the current implementation might be too easy for the compiler to optimize.