Update increment_change_tick to return a strongly-typed Tick#8295
Merged
james7132 merged 1 commit intobevyengine:mainfrom Apr 3, 2023
Merged
Update increment_change_tick to return a strongly-typed Tick#8295james7132 merged 1 commit intobevyengine:mainfrom
increment_change_tick to return a strongly-typed Tick#8295james7132 merged 1 commit intobevyengine:mainfrom
Conversation
joseph-gio
added
A-ECS
alice-i-cecile
approved these changes
Apr 3, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
While migrating the engine to use the
Ticktype in #7905, I forgot to updateUnsafeWorldCell::increment_change_tick.Solution
Update the function.
Changelog
UnsafeWorldCell::increment_change_tickis now strongly-typed, returning a value of typeTickinstead of a rawu32.Migration Guide
The function
UnsafeWorldCell::increment_change_tickis now strongly-typed, returning a value of typeTickinstead of a rawu32.