Skip to content

Remove old post_processing example#8376

Merged
mockersf merged 5 commits intobevyengine:mainfrom
IceSentry:yeet-old-post-processing
Apr 15, 2023
Merged

Remove old post_processing example#8376
mockersf merged 5 commits intobevyengine:mainfrom
IceSentry:yeet-old-post-processing

Conversation

@IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Apr 13, 2023

Objective

  • The old post processing example doesn't use the actual post processing features of bevy. It also has some issues with resizing. It's also causing some confusion for people because accessing the prepass textures from it is not easy.
  • There's already a render to texture example
  • At this point, it's mostly obsolete since the post_process_pass example is more complete and shows the recommended way to do post processing in bevy. It's a bit more complicated, but it's well documented and I'm working on simplifying it even more

Solution

  • Remove the old post_processing example
  • Rename post_process_pass to post_processing

Reviewer Notes

The diff is really noisy because of the rename, but I didn't change any code in the example.

@IceSentry IceSentry added C-Examples An addition or correction to our examples A-Rendering Drawing game state to the screen labels Apr 13, 2023
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future reference: I think it's possible to do the change in two commit to avoid the git mixup.

@james7132 james7132 requested a review from superdump April 15, 2023 00:45
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 15, 2023
Co-authored-by: James Liu <contact@jamessliu.com>
@mockersf
Copy link
Member

Could you also rename the shader post_process_pass.wgsl to the new example name?

@IceSentry
Copy link
Contributor Author

Done!

@mockersf mockersf added this pull request to the merge queue Apr 15, 2023
Merged via the queue into bevyengine:main with commit c7eaedd Apr 15, 2023
@IceSentry IceSentry deleted the yeet-old-post-processing branch April 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants