Expose sorting methods in Children#8522
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom May 1, 2023
Merged
Conversation
nicoburns
approved these changes
May 1, 2023
Contributor
nicoburns
left a comment
There was a problem hiding this comment.
I suspect these methods may be largely obseleted once we have a higher level API for tree creation/modification. But I can see that they will be quite useful in the meantime, and the implementation looks good to me :)
alice-i-cecile
approved these changes
May 1, 2023
Member
|
Yep, I'm very happy to include them for now, and these are likely to be useful for said higher-level abstractions. |
This was referenced Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
orderCSS property, that declaratively re-orders flex box items by a numeric value, similar to z-index, but in space.Solution
We removed the ability to directly construct
Childrenfrom&[Entity]some time ago (#4197 #5532) to enforce consistent hierarchies (RFC 53). If I understand it correctly, it's currently possible to re-order children by usingChildren::swap()orcommands.entity(id).replace_children(...), however these are either too cumbersome, needlessly inefficient, and/or don't take effect immediately.This PR exposes the in-place sorting methods from the
sliceprimitive inChildren, enabling imperatively sorting children in place via&mut Children, while still preserving consistent hierarchies.Changelog
Added
sliceprimitive are now exposed by theChildrencomponent, allowing imperatively sorting children in place (Useful for UI scenarios such as lists)