Conversation
|
I see that CI is currently failing on master unrelated to this PR. |
|
yeah. our math library glam pushed out a minor version change that deprecated accessor methods like |
|
I think this should either be called Lets also take this chance to correct the "cube" shape size and divide the min/max extents by 2.0. Lets just use the Cuboid constructor for simplicity. |
be20a44 to
4ab3925
Compare
|
Renamed to Cuboid. Wikipedia claims a cuboid is more general than what we have which is a rectangular cuboid. Imo either name is fine. Also changed the constructor's length, width, height to be x_length, y_length, z_length to make it clear which axis this refers to.
Not sure exactly what you mean. I have now removed the old |
|
Ah yeah wikipedia does say that "sheared" rectangular prisms are also cuboids. I think its better to roll with the |
Co-authored-by: Jason Lessard <jason.lessard@usherbrooke.ca>
71866c1 to
b95c518
Compare
Based on #377 updated to current master.
I have renamed Prism to Cuboid because this is a more common name and easier to search for.