Fix AsBindGroup derive, texture attribute, visibility flag parsing#8868
Merged
cart merged 4 commits intobevyengine:mainfrom Jun 22, 2023
Merged
Fix AsBindGroup derive, texture attribute, visibility flag parsing#8868cart merged 4 commits intobevyengine:mainfrom
cart merged 4 commits intobevyengine:mainfrom
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Member
|
wow good findings :o 👍 ; Would it be possible to catch this as a test ? |
Contributor
Author
|
Good idea! I've added a test for the derive so that if the parsing fails it would now error. It would be nice to improve the test to check if the visibility is correctly set but I'm not sure how to do that as I need to be able to call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution