Skip to content

fix normal prepass#8890

Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom
IceSentry:fix-normal-prepass
Jun 21, 2023
Merged

fix normal prepass#8890
alice-i-cecile merged 5 commits intobevyengine:mainfrom
IceSentry:fix-normal-prepass

Conversation

@IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Jun 19, 2023

Objective

  • Fix broken normals when the NormalPrepass is enabled

Solution

  • Don't use the normal prepass for the world_normal
  • Only loadthe normal prepass
    • when msaa is disabled
    • for opaque or alpha mask meshes and only for use it for N not world_normal

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior labels Jun 19, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Jun 19, 2023
@JMS55
Copy link
Contributor

JMS55 commented Jun 19, 2023

Closes the non-parallax mapping parts of #8746

@IceSentry
Copy link
Contributor Author

Closes #8746

@nicopap nicopap added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 21, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 21, 2023
Merged via the queue into bevyengine:main with commit 72b4aac Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants