Reflect UUID#8905
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Jun 21, 2023
Joakker:reflect-uuid
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
MrGVSV
added
C-Usability
MrGVSV
reviewed
Jun 20, 2023
| use bevy_reflect_derive::{impl_from_reflect_value, impl_reflect_value}; | ||
| use bevy_utils::Uuid; | ||
|
|
||
| impl_reflect_value!(::bevy_utils::Uuid(Serialize, Deserialize)); |
Member
There was a problem hiding this comment.
Can we also register some other traits? Namely Default, Debug, PartialEq, and Hash?
| #[cfg(feature = "smallvec")] | ||
| pub use self::smallvec::*; | ||
| pub use self::std::*; | ||
| pub use self::uuid::*; |
Member
There was a problem hiding this comment.
Nit: Is this needed? In fact, are any of these needed (since I'm pretty sure none of them export anything)?
Contributor
Author
There was a problem hiding this comment.
I just followed what I saw
Member
There was a problem hiding this comment.
That's fine, we can leave it for now.
killercup
approved these changes
Jun 20, 2023
Contributor
Author
|
Thanks, happy to help! |
MrGVSV
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For those who wish to be able to
#[reflect]stuff using theUuidtypeI'm very unfamiliar with the codebase, so please tell me if I'm missing something