Merged
Conversation
Selene-Amanita
added
C-Bug
IceSentry
reviewed
Jun 21, 2023
IceSentry
approved these changes
Jun 21, 2023
| }, | ||
| ] | ||
| } else { | ||
| position_layout.array_stride *= 2; |
Contributor
There was a problem hiding this comment.
I didn't even realize this was different. Now it's way more obvious 😆
mockersf
approved these changes
Jun 21, 2023
Member
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
works for me in webgpu, webgl2 and native
mockersf
added
the
S-Ready-For-Final-Review
This was referenced Aug 7, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
# Objective The changes made in #12252 introduced an previously fixed bug in webgpu rendering. ## Solution This fix is based on #8910 and applies the same vertex buffer layout assignment for the LineGizmo Pipeline. ## Testing - Tested the 3D Gizmo example in webgpu and webgl environments Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
mockersf
pushed a commit
that referenced
this pull request
Sep 5, 2024
# Objective The changes made in #12252 introduced an previously fixed bug in webgpu rendering. ## Solution This fix is based on #8910 and applies the same vertex buffer layout assignment for the LineGizmo Pipeline. ## Testing - Tested the 3D Gizmo example in webgpu and webgl environments Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix #8908.
Solution
Assign the vertex buffers twice with a single item offset instead of setting the array_stride lower than the vertex layout's size for linestrips.