Skip to content

Change despawn_descendants to return &mut Self#8928

Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom
atheni42:despawn-descendants-return-self
Jun 23, 2023
Merged

Change despawn_descendants to return &mut Self#8928
alice-i-cecile merged 4 commits intobevyengine:mainfrom
atheni42:despawn-descendants-return-self

Conversation

@atheni42
Copy link

Objective

Solution

  • Change function signature despawn_descendants under trait DespawnRecursiveExt.
  • Add single extra test spawn_children_after_despawn_descendants (May be unnecessary)

@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@atheni42 atheni42 changed the title Despawn descendants return self Change despawn_descendants to return &mut Self Jun 22, 2023
@mockersf mockersf added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Hierarchy labels Jun 22, 2023
@alice-i-cecile alice-i-cecile enabled auto-merge June 23, 2023 01:52
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 23, 2023
Merged via the queue into bevyengine:main with commit 29f7293 Jun 23, 2023
@atheni42 atheni42 deleted the despawn-descendants-return-self branch June 23, 2023 03:06
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events and removed A-Hierarchy labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants