do not spend time drawing text with is_visible = false

[marius851000]

I have found that all the process of drawing text are performed, even when the is_visible property of draw is set to false (althought it didn't drawed them before). This should allow instanced invisible text to consume nearly no ressource. For an exemple, on a debug build with 100 texts on firafont-bold, it run at around 1 fps wihout this patch, and at 60 fps with this patch.

[minecrawler]

Just wondering, but what happened to keeping the pyramid small and using early return (or continue in this case)? I really have to re-evaluate my own standards and would love some feedback with PRs of this kind in mind :)

if !draw.is_visible { continue; }

[marius851000]

@minecrawler I used an if x { do stuff } rather than an early continue for no particular reason. (although I never considered using a continue just for reducing the number of indent. Will keep this in mind the next time I'm in a similar situation.).

Also, the clippy error in the CI seem unrelated.

[cart]

Yeah I do like the if !draw.is_visible { continue; } approach a bit more. I made the change (and rebased on master, which has CI fixes)