Merged
Conversation
`Style` flattened `size`, `min_size` and `max_size` to its root struct, causing compilation errors. I uncommented the code to avoid further silent error not caught by CI, but hid the view to keep the same behaviour.
ThierryBerger
force-pushed
the
fix-example-grid
branch
from
5e21aca to
cf2452f
Compare
ThierryBerger
added
C-Examples
ThierryBerger
commented
Jun 23, 2023
less confusing wording
alice-i-cecile
approved these changes
Jun 23, 2023
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good fix! Great example of the dangers of commented out code.
alice-i-cecile
added
the
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styleflattenedsize,min_sizeandmax_sizeto its root struct, causing compilation errors.I uncommented the code to avoid further silent error not caught by CI, but hid the view to keep the same behaviour.