Relaxed runner type from Fn to FnOnce#8961
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jun 29, 2023
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
harudagondi
approved these changes
Jun 27, 2023
alice-i-cecile
approved these changes
Jun 27, 2023
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
This makes sense, although I would expect that almost all use cases meet the tighter bounds.
What motivated this?
Member
|
Aha, the linked PR provides a good motivation :D |
Member
|
@nakedible: does this PR look right to you as well? |
nakedible
approved these changes
Jun 28, 2023
Contributor
nakedible
left a comment
There was a problem hiding this comment.
This is correct and adheres exactly to documentation of set_runner which says:
The runner function
run_fnis called only once by [App::run].
Also, the code that actually calls this:
let runner = std::mem::replace(&mut app.runner, Box::new(run_once));
(runner)(app);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Relax unnecessary type restrictions on
App.runnerfunction.Solution
Changed the type of
App.runnerfromFn(App)toFnOnce(App).