Conversation
superdump
left a comment
There was a problem hiding this comment.
Looks straight forward enough to me.
cart
left a comment
There was a problem hiding this comment.
A reasonable fix for now. Ideally we find a way to prevent these clashes across files. We (and our users) will likely continue to hit this.
I think the best fix for this is to move the binding into the it would mean that the view struct absolutely cannot be used in a slot other than slot 0, without explicitly copy/pasting the struct definition. i think that's fine (and with automatic group 0 it would be irrelevant anyway). it is quite invasive though so i will leave it till after the release. it should also be done for globals, mesh bindings, etc. |
Objective
#5703 caused the normal prepass to fail as the prepass uses
pbr_functions::apply_normal_mapping, which usesmesh_view_bindings::viewto determine mip bias, which conflicts withprepass_bindings::view.Solution
pass the mip bias to the
apply_normal_mappingfunction explicitly.