Fix CAS shader with explicit FullscreenVertexOutput import#8993
Merged
cart merged 1 commit intobevyengine:mainfrom Jun 29, 2023
Merged
Fix CAS shader with explicit FullscreenVertexOutput import#8993cart merged 1 commit intobevyengine:mainfrom
cart merged 1 commit intobevyengine:mainfrom
Conversation
Contributor
|
Items need to be either individually imported, or qualified at point of use. I didn’t do glob imports yet. |
Elabajaba
approved these changes
Jun 29, 2023
Contributor
Elabajaba
left a comment
There was a problem hiding this comment.
I ran into the same crash, and this fixed it.
robtfm
approved these changes
Jun 29, 2023
Member
Author
Ah gotcha gotcha. Then this makes perfect sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Followup bugfix for #5703. Without this we get the following error when CAS (Contrast Adaptive Sharpening) is enabled:
@robtfm I wouldn't expect this to fail. I was under the impression the
#import bevy_core_pipeline::fullscreen_vertex_shaderwould pull "everything" from that file into this one?