Fix morph target prepass shader#9013
Merged
superdump merged 1 commit intobevyengine:mainfrom Jul 2, 2023
Merged
Conversation
nicopap
added
C-Bug
mockersf
approved these changes
Jul 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Since 10f5c92, shadows were broken for models with morph target.
When #5703 was merged, the morph target code in
render/mesh.wgslwas correctly updated to use the new import syntax. However, similar code exists inprepass/prepass.wgsl, but it was never update. (the reason code is duplicated is that theVertexstruct is different for both files).Solution
Update the code, so that shadows render correctly with morph targets.