Fix duplicated chilren in Scene spawn#904
Merged
cart merged 4 commits intobevyengine:masterfrom Nov 22, 2020
Merged
Conversation
Contributor
Author
|
@Moxinilian the CI error is very strange can you force a re-run to see if fixes? |
Member
|
This is an issue with all CI currently, I don't have permission to do anything about it. I'll make sure cart is aware. |
0e10753 to
7413e32
Compare
cart
reviewed
Nov 22, 2020
Member
cart
left a comment
There was a problem hiding this comment.
I think this is a reasonable short term fix. I made one small change (see comment below)
| } | ||
| } | ||
|
|
||
| impl DerefMut for Children { |
Member
There was a problem hiding this comment.
we need some way to re-order children. order already matters for things like UI, and once we have an editor it will matter for "scene organization".
I added this to enable those scenarios:
children.swap(a_index, b_index);
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #889,
TLDR;
The Problem
Childrencomponent while spawning a scenetransform_propagate_systemtook 13ms in release with a small skeleton tree ~20 bonesSceneis usingWorldBuilder.with(Parent(...))(still wrong for other reasons)The Fix
FromResourcesandMapEntitiesforPrevousParentChildrenusing adebug_assertChildren.0andPreviousParent.0are nowpub(crate), their contents are a reflect ofParentConclusion
This is the best short term fix, it will make so that the only true correct way of creating
Scenewill beWorldBuilder.with_childrenwhich has no caviats