Allow despawning of hierarchies in threadlocal systems#908
Merged
cart merged 3 commits intobevyengine:masterfrom Nov 26, 2020
Merged
Allow despawning of hierarchies in threadlocal systems#908cart merged 3 commits intobevyengine:masterfrom
cart merged 3 commits intobevyengine:masterfrom
Conversation
Moxinilian
added
A-ECS
Member
|
I like this, but can we revert back to recursion instead of using a heap-based stack? |
This way, threadlocal systems can despawn hierarchies.
svents
force-pushed
the
despawn_threadlocal
branch
from
072c8f6 to
b24c41a
Compare
Contributor
Author
|
Done. The swapping of children might be worth keeping, but if not, please just rebase it out. |
Member
|
Definitely worth keeping. Im all for reducing allocations! |
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, one can despawn hierarchies with commands, but not conveniently via the world. I made the function in question public. In addition, I tried to write the recursive despawn a bit more compactly (in separate commits).