avoid exclusive lock during update_asset_storage#909
Merged
cart merged 2 commits intobevyengine:masterfrom Nov 22, 2020
blamelessgames:asset-server-lock-scope
Merged
avoid exclusive lock during update_asset_storage#909cart merged 2 commits intobevyengine:masterfrom blamelessgames:asset-server-lock-scope
update_asset_storage#909cart merged 2 commits intobevyengine:masterfrom
blamelessgames:asset-server-lock-scope
Conversation
Member
|
yeah asset lifecycle events should be pretty rare, so grabbing the lock on each event doesn't seem terrible. The tradeoff is that we get way more "lock-ey" when we load many assets at once. We could optimize that by adding a |
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed a coarsely held exclusive lock in
update_asset_storagethat was causing contention - occasionally one version or another of the wrapping system would be held for 10+ms in my profiling.narrowed the lock scope to the point of use. if this solution seems too quick-and-dirty i'm willing to re-examine