Revert "Fix UI corruption for AMD gpus with Vulkan (#9169)"#9237
Merged
superdump merged 1 commit intobevyengine:mainfrom Jul 25, 2023
Merged
Revert "Fix UI corruption for AMD gpus with Vulkan (#9169)"#9237superdump merged 1 commit intobevyengine:mainfrom
superdump merged 1 commit intobevyengine:mainfrom
Conversation
Member
Could we try moving UI earlier? |
Contributor
Author
I don't think so? Afaik ui shouldn't be before post processing, and you need to do msaa resolve before you do post processing. |
Member
|
It seems other game engines can render UI either as overlay, same as Bevy does, and this is after post processing, or as camera, and then the user can choose where and which post processing effects will be applied to UI. As Bevy UI is overlay, it makes sense to revert that change. |
mockersf
approved these changes
Jul 23, 2023
superdump
approved these changes
Jul 25, 2023
DGriffin91
approved these changes
Jul 25, 2023
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #9234
re-breaks: The issues that were linked in #9169
Solution
Revert the PR that broke tonemapping/postprocessing/etc.
Any passes that are post msaa resolve need to use the main textures, not the msaa texture.
Changelog
Idk what to put here since it's a revert.