Add event for clicks

[atheni42]

Objective

• Add click events that capture the press release cycle of a UI node being clicked
• Addresses Add event for clicks #9047

Solution

• Add API to send Click events when an Interaction goes from Interaction::Hovered to Interaction::Pressed
• Incorporate Click event sends into UiPlugin by default
• Refactor game_menu.rs example to use Click rather then manually checking the Interaction

As an aside, I haven't changed any other bevy example that could use Click just yet. If my implementation is along the lines of what people want then happy to skim through the UI examples and migrate them to use Click if wanted.

Possibly interested party @Shatur :)

[atheni42]

Made some changes @Shatur, let me know what you think. Found some other examples that I'm happy to change to Click's as well

[Shatur]

A few more suggestions

[Shatur]

Looks like we have more examples, could you update them too?

examples/ui/size_constraints.rs
examples/ui/display_and_visibility.rs
examples/ui/button.rs
examples/mobile/src/lib.rs
crates/bevy_ui/src/focus.rs

[atheni42]

Apologies still working on this and will hopefully have it done in a week probably. Real life nonsense currently imposing. :(

[Shatur]

Take your time, hope everything is alright!

[Shatur]

@AnthonyKalaitzis hope that you are doing okay! Let me know if you are not longer interested, I will finish this PR for you.

[atheni42]

@Shatur Mega apologies, fell of the face of the earth there for a bit (employment interviews zzzzz). Will have the other examples finished by today or tomorrow hopefully. Just pushed one to let people know I'm still alive and working on it. Sorry again for the delay 😢

[Bytekeeper]

Just a small question: Why not send the click event in ui_focus_system? That way LastInteraction would not even be required?

[Shatur]

Just a small question: Why not send the click event in ui_focus_system?

This sounds like a great suggestion!
I suggested LastInteraction because this is what I used in my game because without touching Bevy code.

@AnthonyKalaitzis could you try the suggested approach? I think you can do it here:
https://github.com/AnthonyKalaitzis/bevy/blob/f07e153682b6c4129343db09c4ff8c938019c9fd/crates/bevy_ui/src/focus.rs#L178

[Shatur]

Thank you a lot!
One minor nitpick that you can apply from browser and we are good to go

[atheni42]

Big thanks @Shatur for sticking with me through that painful process 😄! Very much a learning experience for me, haven't done much open source stuff before. Big thanks 🥇

[nicoburns]

I think at some point we'll want better handling of cases where there are multiple elements on top of each other (so the top element captures the event, and it doesn't fire on all overlapping elements). But this seems like an improvement over what we have.

[Shatur]

@AnthonyKalaitzis could you resolve conflicts?

[alice-i-cecile]

Adopted in #10141. Don't worry, credit will be shared if this gets merged and your ongoing participation in that thread would be welcome.