Refactor Time API and internals#934
Merged
cart merged 8 commits intobevyengine:masterfrom Nov 28, 2020
ambeeeeee:amber-time
Merged
Refactor Time API and internals#934cart merged 8 commits intobevyengine:masterfrom ambeeeeee:amber-time
cart merged 8 commits intobevyengine:masterfrom
ambeeeeee:amber-time
Conversation
Rename `Time` members Change `Time` API
cart
reviewed
Nov 27, 2020
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
Looks good to me. Just a couple small nits
Moxinilian
added
C-Code-Quality
cart
approved these changes
Nov 28, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes a few things about
Time:instanttolast_updateto increase clarityTimefunctionalityThe added test checks all the functionality of
Time, which should be useful.I'd like some feedback from @cart, since I was wondering if we should make
Time::updateprivate (pub crateor similar) since there's little reason for it to be used outside of bevy.