Add removal_detection example#945
Merged
cart merged 2 commits intobevyengine:masterfrom Nov 30, 2020
lukors:removal_detection-example
Merged
Add removal_detection example#945cart merged 2 commits intobevyengine:masterfrom lukors:removal_detection-example
cart merged 2 commits intobevyengine:masterfrom
lukors:removal_detection-example
Conversation
ambeeeeee
suggested changes
Nov 29, 2020
Contributor
ambeeeeee
left a comment
ambeeeeee
left a comment
There was a problem hiding this comment.
Code looks good, only issue is where in the changelog you placed the change.
Contributor
Author
|
Ah, thanks! I didn't see the headings because there were no newlines before them, so my markdown syntax highlighting didn't highlight them. I added newlines before and after the headings in the changelog for the upcoming version so it matches the changelogs for the previous versions. And I moved the change to |
ambeeeeee
approved these changes
Nov 29, 2020
Moxinilian
added
A-ECS
Member
|
Well done! The comments are clear and helpfully walk the user through each step. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an example that shows how you can know when a component has been removed, so you can react to it.
Related to #941