Fix RenderResources index slicing#948
Merged
cart merged 1 commit intobevyengine:masterfrom Nov 30, 2020
Merged
Conversation
joshuajbouw
force-pushed
the
render-resources-index
branch
2 times, most recently
from
343356a to
77f0165
Compare
Moxinilian
added
C-Code-Quality
Member
|
Makes sense to me! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small patch fix. Since
RenderResourcesis typically implemented through the proc macro, internally should be hygienic enough to not cause unexpected panics. This patch fixes for exampleclippy::indexing_slicingwhich is a some-what common clippy check.Going through a few of the clippy lints in
bevy_tilemapand fixing whats up as suggested, this was one of them. Obviously I can't fix it without fixing it onbevyfirst or implementingRenderResourcesby hand.