Align bevy_input::Touch API with other similar APIs #952
Align bevy_input::Touch API with other similar APIs #952cart merged 1 commit intobevyengine:masterfrom ambeeeeee:amber-touch-api
Conversation
CleanCut
left a comment
There was a problem hiding this comment.
Seems consistent with the Timer changes.
Should delta and distance also be marked #[inline] for consistency?
I decided not to immediately since they're not simple getters and setters, but we'll see what @cart thinks. |
|
Yeah whether or not to inline is always an interesting question. I think we should only "always default" to inlining simple field accesses. Everything else should probably be informed by benchmarks (both perf and compile time). |
Great, it's nice to have a guideline. 👍 |
With the recent changes to APIs in
TimeandTimer, I came across Touch which would benefit from the same change. Upon code approval I can add it to the changelog.My last PR randomly killed itself when I was messing with the git history, odd.