Test more areas of the codebase#953
Merged
cart merged 13 commits intobevyengine:masterfrom Dec 1, 2020
ambeeeeee:amber-testing
Merged
Test more areas of the codebase#953cart merged 13 commits intobevyengine:masterfrom ambeeeeee:amber-testing
cart merged 13 commits intobevyengine:masterfrom
ambeeeeee:amber-testing
Conversation
memoryruins
added
the
C-Code-Quality
ambeeeeee
changed the title
ambeeeeee
changed the title
Contributor
Author
|
Okay that's all the areas of the codebase I want to write tests for at this point. |
cart
reviewed
Dec 1, 2020
cart
reviewed
Dec 1, 2020
joshuajbouw
suggested changes
Dec 1, 2020
Member
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
Just a few extra areas to resolve. Looks fine to me otherwise.
remove unnecessary `+ '_` lifetime bound
Contributor
Author
|
How am I that blind hahah |
Member
|
Haha no worries. Everyone makes those kinds of errors 😄 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: CI is supposed to fail, pretty sure there's a bug my tests caught.
I have concerns about my
FaceTowardtest, since floating point.Also why can't I get the "updated changelog" commits to go away ):