Rename reflect 'hash' method to 'reflect_hash'#954
Merged
cart merged 2 commits intobevyengine:masterfrom Dec 1, 2020
CleanCut:reflect-papercut
Merged
Rename reflect 'hash' method to 'reflect_hash'#954cart merged 2 commits intobevyengine:masterfrom CleanCut:reflect-papercut
cart merged 2 commits intobevyengine:masterfrom
CleanCut:reflect-papercut
Conversation
memoryruins
added
the
C-Code-Quality
cart
reviewed
Dec 1, 2020
Member
|
Yeah this definitely resolve #943 in my mind / is my ideal solution to the problem |
Member
|
Hexasphere pushed a breaking minor version change (which broke ci). We've updated master, so a rebase should fix the problem. |
cart
approved these changes
Dec 1, 2020
…h std::hash::Hash::hash to resolve #943.
…ementations of PartialEq on primitives.
Member
Author
|
I rebased and force-pushed...but CI is just sitting there and not starting. 🤷♂️ |
Member
|
looks like it finally worked itself out! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cart is this what you had in mind to resolve #943? (It works for me.)
hashmethod toreflect_hashpartial_eqmethod toreflect_partial_eq