Skip to content

Tracing chrome span names#979

Merged
cart merged 3 commits intobevyengine:masterfrom
superdump:tracing-chrome-span-names
Dec 3, 2020
Merged

Tracing chrome span names#979
cart merged 3 commits intobevyengine:masterfrom
superdump:tracing-chrome-span-names

Conversation

@superdump
Copy link
Contributor

This should work in theory but for some reason the tracing-chrome profile data is not being properly flushed to the .json file it creates. I wonder if the thread-local resource isn't doing what we want it to?

@cart
Copy link
Member

cart commented Dec 2, 2020

Works for me!

cargo run --example 3d_scene --release --features trace,trace_chrome

image

@memoryruins memoryruins added core C-Feature A new feature, making something new possible labels Dec 2, 2020
@superdump
Copy link
Contributor Author

Works for me!

cargo run --example 3d_scene --release --features trace,trace_chrome

image

I forgot to enable the trace feature. Works for me too now. Yey!

@cart cart merged commit 59010ca into bevyengine:master Dec 3, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Feature A new feature, making something new possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants