changing toolchain from action-rs to dtolnay#21
Closed
vital14 wants to merge 4 commits intobevyengine:mainfrom
Closed
changing toolchain from action-rs to dtolnay#21vital14 wants to merge 4 commits intobevyengine:mainfrom
vital14 wants to merge 4 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Dec 20, 2022
Member
|
On board with this idea. Ping me if I forget to keep approving CI here please. |
alice-i-cecile
approved these changes
Jan 17, 2023
mockersf
requested changes
Jan 17, 2023
Member
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
you didn't change the action parameters. You should remove the toolchain, profile, components or override parameters
Author
|
@alice-i-cecile could you please approve the ci to run this changes? |
Member
|
Nothing is attempting to run, from what I can see 🤔 |
Member
|
your workflow definition is not valid: https://github.com/bevyengine/bevy_github_ci_template/actions/runs/4055140985 |
Member
|
Ping @vital14, I'd like to fix this up for the upcoming Jam :) |
Member
|
done in #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing into script the references to action-rs toolchain that is not updating, and using dtolnay version
#18