Skip to content

Try to guess license and make PR instead of issue. #5

@bf4

Description

@bf4

Some repos only take PRs, but not issues.

I get asked periodically why I create issues and not PRs. So, here's an issue describing some of the technical concerns.

To do this, there's a number of things to consider, though there may be some mvp.

  1. Is there a license file (accommodate spelling variants), and if so which license is it (match against known licenses)
  2. Scrape the README for possible licenses
  3. Figure out which file to change, the gemspec, the Rakefile, a custom gem task?
  4. Determine if that change has already been made, but is unreleased
  5. Handle multiple licenses
  6. Tweaking the changes in the PR would now be dependent on my branch
  7. I would end of forking quite a few repos!

Ironically, if there were a script good enough at guessing the license for a project, rubygems.org might not need to rely on the gemspec. 😄

Other concerns would be

  • to make the PR attractive
  • to ensure it is inline with Github ToS

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions