Skip to content

Comments

feat: Allow passing a working-directory to npm publish#55

Merged
boredland merged 1 commit intomainfrom
path
Aug 19, 2025
Merged

feat: Allow passing a working-directory to npm publish#55
boredland merged 1 commit intomainfrom
path

Conversation

@boredland
Copy link
Contributor

so we can release a subdirectory, if need be

so we can release a subdirectory, if need be
@boredland boredland requested review from Copilot and sakulstra August 19, 2025 08:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for publishing npm packages from subdirectories by introducing a configurable working directory parameter to the release workflow.

  • Adds an optional path input parameter to the workflow with a default value of '.'
  • Modifies the npm publish step to use the specified working directory

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

🌈 Test Results
Compiling 1 files with Solc 0.8.20
Solc 0.8.20 finished in 7.96ms
Compiler run successful!

Ran 1 test for src/test/Test.t.sol:TestB
[PASS] test_c() (gas: 145)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 364.97µs (63.95µs CPU time)

Ran 1 test suite in 22.80ms (364.97µs CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)
🌈 Test Results zksync
Compiling 1 files with Solc 0.8.19
Solc 0.8.19 finished in 7.87ms
Compiler run successful!

Compiling 1 files with zksolc and solc 0.8.19
zksolc and solc 0.8.19 finished in 49.71ms
Compiler run successful!

Ran 1 test for zksync/test/Test.t.sol:TestB
[PASS] test_c() (gas: 146)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 348.31µs (108.10µs CPU time)

Ran 1 test suite in 23.32ms (348.31µs CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

@github-actions
Copy link

♻️ Forge Gas Snapshots

Seems like you are not measuring gas of any operations yet. 🤔
Consider adding some snapshot tests to measure regressions & improvements.

@boredland boredland merged commit a4997b3 into main Aug 19, 2025
1 of 2 checks passed
@boredland boredland deleted the path branch August 19, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants