fix: Simplify release job conditions in workflow#56
Merged
Conversation
🌈 Test ResultsCompiling 1 files with Solc 0.8.20
Solc 0.8.20 finished in 7.91ms
Compiler run successful!
Ran 1 test for src/test/Test.t.sol:TestB
[PASS] test_c() (gas: 145)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 398.37µs (83.06µs CPU time)
Ran 1 test suite in 22.96ms (398.37µs CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)🌈 Test Results zksyncCompiling 1 files with Solc 0.8.19
Solc 0.8.19 finished in 7.83ms
Compiler run successful!
Compiling 1 files with zksolc and solc 0.8.19
zksolc and solc 0.8.19 finished in 49.73ms
Compiler run successful!
Ran 1 test for zksync/test/Test.t.sol:TestB
[PASS] test_c() (gas: 146)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 294.50µs (85.11µs CPU time)
Ran 1 test suite in 23.06ms (294.50µs CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests) |
♻️ Forge Gas SnapshotsSeems like you are not measuring gas of any operations yet. 🤔 |
sakulstra
previously approved these changes
Aug 26, 2025
boredland
commented
Aug 26, 2025
So that users of the workflow can decide if they'd like to add further constraints. I think putting assumptions on the commit message is a bit to much.
boredland
force-pushed
the
commit-msg-check
branch
from
770e651 to
a0c8f1b
Compare
sakulstra
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that users of the workflow can decide if they'd like to add further constraints. I think putting assumptions on the commit message is a bit over the top.