forked from opentracing/opentracing-java
-
Notifications
You must be signed in to change notification settings - Fork 0
RFC: demonstrate some concepts #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhs
wants to merge
13
commits into
master
Choose a base branch
from
bhs/scopes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6579cfb
Add an AutoFinisher that can do the refcounting
bhs 40271b4
Fold Span into BaseSpan, add ActiveSpan.Observer
bhs 72ffc0e
Make things spiritually backwards-compatible
bhs 648576b
Add some comments
bhs eace002
Remove unused interface method
bhs 7bddaaa
Sanity-checked new API, about to delete old
bhs ea1fb56
Deleted enough to make the tests pass again
bhs 397bd07
Added some comments
bhs b599565
Add more comments and a convenience method
bhs 5ca30f6
Use 1.8 features
bhs 6ef8be7
Shorten a method name and revert README
bhs f5f7076
Add admonition
bhs 2eca5c1
Adjust the API to make finish()ing harder to miss
bhs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
109 changes: 0 additions & 109 deletions
109
opentracing-api/src/main/java/io/opentracing/ActiveSpan.java
This file was deleted.
Oops, something went wrong.
50 changes: 0 additions & 50 deletions
50
opentracing-api/src/main/java/io/opentracing/ActiveSpanSource.java
This file was deleted.
Oops, something went wrong.
143 changes: 0 additions & 143 deletions
143
opentracing-api/src/main/java/io/opentracing/BaseSpan.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Copyright 2016-2017 The OpenTracing Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package io.opentracing; | ||
|
|
||
| import java.io.Closeable; | ||
|
|
||
| /** | ||
| * A {@link Scope} formalizes the activation and deactivation of a {@link Span}, usually from a CPU standpoint. | ||
| * | ||
| * <p> | ||
| * Many times a {@link Span} will be extant (in that {@link Span#finish()} has not been called) despite being in a | ||
| * non-runnable state from a CPU/scheduler standpoint. For instance, a {@link Span} representing the client side of an | ||
| * RPC will be unfinished but blocked on IO while the RPC is still outstanding. A {@link Scope} defines when a given | ||
| * {@link Span} <em>is</em> scheduled and on the critical path. | ||
| */ | ||
| public interface Scope extends Closeable { | ||
| /** | ||
| * End this {@link Scope}, updating the {@link ScopeManager#active()} in the process. | ||
| */ | ||
| @Override | ||
| void close(); | ||
|
|
||
| /** | ||
| * @return the {@link Span} that's been scoped by this {@link Scope} | ||
| */ | ||
| Span span(); | ||
|
|
||
| /** | ||
| * {@link Observer} is a simple API for observing the opening/closing of {@link Scope} instances. | ||
| * | ||
| * @see ScopeManager#activate(Span, Observer) | ||
| * @see Tracer.SpanBuilder#startActive(Observer) | ||
| * @see Span#activate(Observer) | ||
| */ | ||
| interface Observer { | ||
| /** | ||
| * A trivial, static {@link Scope.Observer} that finishes the underlying {@link Span} on scope close. | ||
| */ | ||
| Observer FINISH_ON_CLOSE = new FinishOnCloseScopeObserverImpl(); | ||
|
|
||
| /** | ||
| * Invoked just after the {@link Scope} becomes active. | ||
| */ | ||
| void onActivate(Scope scope); | ||
|
|
||
| /** | ||
| * Invoked just before the {@link Scope} closes / is deactivated. | ||
| */ | ||
| void onClose(Scope scope); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @see Scope.Observer#FINISH_ON_CLOSE | ||
| */ | ||
| class FinishOnCloseScopeObserverImpl implements Scope.Observer { | ||
| @Override | ||
| public void onActivate(Scope scope) {} | ||
|
|
||
| @Override | ||
| public void onClose(Scope scope) { | ||
| scope.span().finish(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kinda/sorta replaces ActiveSpan