Skip to content

Existance checks for create and drop enums and cascade: true for drop_enum#27

Merged
bibendi merged 2 commits intobibendi:masterfrom
hosembafer:feature/existance-checks-for-create-and-drop-enums
Jul 25, 2020
Merged

Existance checks for create and drop enums and cascade: true for drop_enum#27
bibendi merged 2 commits intobibendi:masterfrom
hosembafer:feature/existance-checks-for-create-and-drop-enums

Conversation

@hosembafer
Copy link
Copy Markdown
Contributor

@hosembafer hosembafer commented Jul 25, 2020

#24

What's inside

  • add if_not_exists: true option to create_enum
  • add if_exists: true option to drop_enum
  • add cascade: true to drop_enum

Checklist:

  • I have added tests

- add cascade option to drop_enum
- remove raise_error warnings by adding specific error

Refs bibendi#24
@hosembafer
Copy link
Copy Markdown
Contributor Author

Also, would be nice to document if_not_exists, if_exists, cascade or it's enough to rely on Github's hover tooltip annotation?

@bibendi
Copy link
Copy Markdown
Owner

bibendi commented Jul 25, 2020

Wow! Brilliant!
I don't know what Github's hover tooltip annotation is, but any documentation is always desirable. So, as you wish :)

@hosembafer
Copy link
Copy Markdown
Contributor Author

hosembafer commented Jul 25, 2020

When hovering on code snippet more than 1-2 sec, tooltip appearing.
I think would be better to issue a new ticket and improve API documentation overall if you think so. Yep, so this PR can be merged regardless of the documentation.

github-tooltip-annotation

@bibendi
Copy link
Copy Markdown
Owner

bibendi commented Jul 25, 2020

Got it!

@bibendi bibendi merged commit 02062c3 into bibendi:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants