FIX: copyfile()/symlinks on Linux, Matlab < R2020a#22
Open
octomike wants to merge 2 commits intobids-apps:masterfrom
Open
FIX: copyfile()/symlinks on Linux, Matlab < R2020a#22octomike wants to merge 2 commits intobids-apps:masterfrom
octomike wants to merge 2 commits intobids-apps:masterfrom
Conversation
Collaborator
|
There is now a function |
Author
|
Okay, cool. So should I just revert the changes and change copyfile() to spm_copy() and leave this here until spm_copy is updated? |
Collaborator
|
Yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried running the SPM container on
ds000001which I pulled with datalad. It turns out that datalad is using symbolic links for the images inanat/andfunc/etc pointing to a.git-annexfolder two levels above.Unfortunately,
copyfile()on Linux with Matlab <= 2019b does not dereference the file and when SPM is copying a relative symlink to the tmp/output folder, the link breaks.This PR is checking if we are on Linux on Matlab < 2020a (with an ugly versioncmp hack) and uses
system('cp -rL...')instead ofcopyfile().Also, as I mention in the comment, it would probably be much nicer to keep the symbolic links for all platforms, but I'm having a hard time coming up with a portable solution for that. And I'm also not entirely sure this is compatible with SPM's behavior (would it modify source files in that case?)