[WIP] refactor narrowing, add test, run narrow before copying#29
[WIP] refactor narrowing, add test, run narrow before copying#29WillForan wants to merge 12 commits intobids-apps:masterfrom
Conversation
|
will try to review in the coming days makes me think that this kind of thing should probably be delegated to bids-matlab which is an update and better version of spm_bids |
|
but already thanks for adding tests!!! |
|
Note to self:
|
There was a problem hiding this comment.
Do you think you could rewrite this test to be used directly by matlab testing framework?
Ideally with setup and teardown functions.
https://nl.mathworks.com/help/matlab/matlab_prog/write-test-using-setup-and-teardown-functions.html
If you don't have the bandwidth, let me know and I can give it a go
|
Seems that we have a path issue when testing it: |
that's because the new m file you have added is not copied into the container: Line 41 in 68e5b93 |
for more information, see https://pre-commit.ci
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/hadolint/hadolint: v2.13.0-beta → v2.13.1-beta](hadolint/hadolint@v2.13.0-beta...v2.13.1-beta)
updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/hadolint/hadolint: v2.13.1-beta → v2.14.0](hadolint/hadolint@v2.13.1-beta...v2.14.0)
2 participants
also address issue #27 and could supersede pull request #28
I pulled out the
metalength check into it's own function and added a test. I also moved thenarrow_participantscall before temporary files are copied.The test is only checking narrowing works, not any down stream effects. And I'm worried I've likely overlooked some important considerations. Please feel free to ruthlessly reject