Skip to content

Conversation

@mcampa
Copy link
Contributor

@mcampa mcampa commented Oct 25, 2016

  • added tests for the localizer library
  • deleted compiler code that is not used
  • Exposes localeName to the template context

@lord2800 @mattolson @bc-ong @sherrybc

@lord2800
Copy link
Contributor

Is there a way for the end visitor to override the locale? Browsers are inconsistent at best about sending the right locale headers.

👍 regardless.

@mcampa
Copy link
Contributor Author

mcampa commented Oct 25, 2016

Visitors can set the browser to send whatever locale they want, but stapler/paper will only set localeName to a value supported by the theme.

@lord2800
Copy link
Contributor

Right, but let's say I'm a visitor whose browser is set to en-CA but I want en-US or fr-CA. Can I override the browser's decision without changing the browser somehow?

@mcampa
Copy link
Contributor Author

mcampa commented Oct 25, 2016

No, we currently don't do that. But is doable. We could store the preferred language in a cookie for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants