Skip to content

removed regular package for megatron model#117

Closed
jtboing wants to merge 1 commit intobigscience-workshop:mainfrom
jtboing:main
Closed

removed regular package for megatron model#117
jtboing wants to merge 1 commit intobigscience-workshop:mainfrom
jtboing:main

Conversation

@jtboing
Copy link

@jtboing jtboing commented Sep 26, 2021

Removed regular package (init.py) on megatron model subfolder and adapted calls for imports in various scripts.

@stas00
Copy link
Contributor

stas00 commented Nov 19, 2021

oh, this fell between cracks, my apologies.

but I have no perms to push into this branch... I will try to copy it

I replayed it here via cherry-pick so the credits are set correctly to the original author:
#192

@stas00
Copy link
Contributor

stas00 commented Nov 19, 2021

continued at #192

@stas00 stas00 closed this Nov 19, 2021
@jtboing
Copy link
Author

jtboing commented Nov 19, 2021

oh, this fell between cracks, my apologies.

but I have no perms to push into this branch... I will try to copy it

I replayed it here via cherry-pick so the credits are set correctly to the original author: #192

I see. It is because of the permissions of the main branch? Or is it because of branches from my fork?

@stas00
Copy link
Contributor

stas00 commented Nov 19, 2021

Typically this means that your PR from your private fork was set to not allow maintainers to push. Usually it's a setting on the right side of the PR. But only you can see that.

@jtboing
Copy link
Author

jtboing commented Nov 25, 2021

Right. Thanks for the tip, I'll try to set this option to make it more convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants