Closed
Conversation
added 2 commits
July 25, 2021 22:30
Contributor
|
FWIW, testing this branch I get no difference in the speed. Unless you meant it improves when used with #18? |
Member
Author
|
I think it's clear that in current case tokenizer is not the bottleneck, ie otherwise adding workers would help. I'm hoping with #18 it's going to be faster |
Member
Author
|
Okay so the code makes no difference for is the flag |
adammoody
pushed a commit
to adammoody/Megatron-DeepSpeed
that referenced
this pull request
Dec 20, 2021
* initial commit * script fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to leverage HF's tokenizers'
batch_encodemethod. I observed a 30% speedup on my colab (with 2 workers ... so I don't know how it translates for c4 with 16/32 workers), so we might need to test out with long runs? Also #18 should be able to leverage this feature nicely as each work write directly on disk.