Conversation
thomasw21
approved these changes
May 24, 2022
Member
thomasw21
left a comment
There was a problem hiding this comment.
LGTM. I think ideally we'd want to expose that via an command line argument, but the hotfix makes sense right now. Thanks!
Contributor
Author
|
Indeed, I will work on the cmd line arg before merging. |
Contributor
Author
|
Done. I will rebase the live auto-sync branch and adjust the slurm script to add Thank you! |
Merged
Contributor
Author
|
so I'm merging this, right? not sure if we are going to hear from @TevenLeScao |
Collaborator
|
Sorry, don't really have the bandwidth to check this, go ahead if it's necessary |
Member
|
Looks alright to me! Feel free to merge! Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the full discussion please see: https://huggingface.slack.com/archives/C01NHER1JLS/p1652884593515729
The summary is here https://github.com/bigscience-workshop/bigscience/blob/master/train/tr11-176B-ml/chronicles.md#2022-05-18-hanging-at-eval-redux
py-spytracer worked perfectly so we had all the info needed to analyse the problemvalid_dataloadersto usenum_workers=0to work around it - it slows things down by a 5 TFLOPs on training, so we kept the training atnum_workers=2We are currently running already on this code as I hacked directly the local branch we were running from #272
@TevenLeScao, @thomasw21