WIP: add oscar slurm script for preprocess_data_dist#4
Closed
adammoody wants to merge 3 commits intobigscience-workshop:masterfrom
Closed
WIP: add oscar slurm script for preprocess_data_dist#4adammoody wants to merge 3 commits intobigscience-workshop:masterfrom
adammoody wants to merge 3 commits intobigscience-workshop:masterfrom
Conversation
Author
|
If you verify this works well and correctly at smaller nodes counts, you might try scaling it higher. It has scaled well for me up to 64 nodes so far. |
Author
|
Oh, and for a quick test, add something like |
5 tasks
Contributor
|
Hi Adam, I have just noticed your WIP PR here - is this still relevant and then let's merge it, or if not move/close it? |
Author
|
Thanks, @stas00 . No need to merge this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't run on JZ, but for a concrete example, I think a script like the one in this PR could be used with the new
preprocess_data_dist.pyscript. This requires the JSON support added in PR bigscience-workshop/Megatron-DeepSpeed#60To process a JSON file, the script first generates an "index" that records the starting byte offset and length of each line in the source JSON file. That index file is stored beside the source JSON file to be reused in future runs. The index enables quick random access to the (variable-length) lines in the JSON file.
In the example SLURM script in this PR, for the source file:
the
preprocess_data_dist.pyscript will create the following files as a result of indexing the source JSON file: