-
Notifications
You must be signed in to change notification settings - Fork 53
Added compatibility for XNLI #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compatibility for XNLI #34
Conversation
…e source can be different, example: prompt from XNLI En but data to eval from XNLI Fr
|
Example to run eval on XNLI |
VictorSanh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @lintangsutawika! lgtm! feel free to merge!
| "--template_config_name", | ||
| type=str, | ||
| default=None, | ||
| help="The name of the dataset_config_name of the template we want to use, example: use XNLI En prompts for XNLI Fr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is using english prompts on the french XNLI something good? Like I understand it's some sort of measure multilinguality, but I would have expected to have a bunch of frnech prompts for the XNLI fr ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought using english prompts for XNLI is indeed what we wanted to accomplish?
Anyway, evaluating XNLI with prompts and dataset in the same language only requires the Promptsource part be updated. So --template_config_name adds more flexibility while not needing to change too much of the code to be able to eval on multiple multilingual settings.
|
Looks good to me besides the fact that prompts are english prompts (I expected to have them in their languages). |
i think this is fine. A bunch of the prompts coming from the eval hackathon are code switching |
|
Thanks @lintangsutawika |
50c27b5
into
bigscience-workshop:thomas/support_new_accelerate_api
added template_config_name arg so that the dataset and prompt template source can be different, example: prompt from XNLI En but data to eval from XNLI Fr