Add TypeScript union string type for custom event names#2139
Merged
alexpetros merged 1 commit intobigskysoftware:devfrom Jan 2, 2024
cngJo:add-type-for-htmx-event
Merged
Add TypeScript union string type for custom event names#2139alexpetros merged 1 commit intobigskysoftware:devfrom cngJo:add-type-for-htmx-event
alexpetros merged 1 commit intobigskysoftware:devfrom
cngJo:add-type-for-htmx-event
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds more type-safety to extension developers, since the event name in
onEventis now no longer of typestring, but uses a. new union-type of all available event names as string.The type and the available events are based on what's written in the docs.
Corresponding issue: there is no issue atm. please let me know when I should create one.
Testing
This only changes the type definition, not the actual source-code, therefore no tests are provided.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded