[Website]: Fix demo-server-info panel rendering issue#2188
Merged
alexpetros merged 1 commit intobigskysoftware:masterfrom Jan 17, 2024
Merged
[Website]: Fix demo-server-info panel rendering issue#2188alexpetros merged 1 commit intobigskysoftware:masterfrom
alexpetros merged 1 commit intobigskysoftware:masterfrom
Conversation
hawkticehurst
changed the title
4 tasks
alexpetros
approved these changes
Jan 17, 2024
Collaborator
alexpetros
left a comment
alexpetros
left a comment
There was a problem hiding this comment.
This kind of thing is totally fine to PR, the guidelines are stricter for the feature requests :)
Contributor
Author
|
Okay great, I kind of figured but didn’t want to assume. Thanks for clarifying! 😊 |
lsymds
pushed a commit
to lsymds/htmx
that referenced
this pull request
Jan 20, 2024
…#2188) Add z-index to demo server info panel so it is rendered above example page content
rekado
pushed a commit
to rekado/htmx
that referenced
this pull request
Feb 9, 2024
…#2188) Add z-index to demo server info panel so it is rendered above example page content
FraserChapman
pushed a commit
to FraserChapman/htmx
that referenced
this pull request
Feb 16, 2024
…#2188) Add z-index to demo server info panel so it is rendered above example page content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #2187
Fixes a tiny visual bug on the docs website where the demo-server-info panel is not rendering above some example page content (namely the link emoji).
Before fix:
After fix:
Also, apologies if I'm jumping the gun by sending this PR before explicit approval of the issue I submitted. Since this was a one-line CSS fix, I thought it wouldn't hurt to just send in a PR at the same time as the issue.
If, in the future, you would like me to wait for explicit approval please let me know 😊
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded