Skip to content

Clarify hx-validate documentation#2221

Merged
alexpetros merged 1 commit intobigskysoftware:masterfrom
MikeMoolenaar:improve-hx-validate-docs
Jan 22, 2024
Merged

Clarify hx-validate documentation#2221
alexpetros merged 1 commit intobigskysoftware:masterfrom
MikeMoolenaar:improve-hx-validate-docs

Conversation

@MikeMoolenaar
Copy link
Copy Markdown
Contributor

@MikeMoolenaar MikeMoolenaar commented Jan 20, 2024

Fixes #2185

Description

The hx-validate documentation says "Form elements do this by default, but other elements do not" which is quite confusing, I interpreted this to also mean <input> elements validate by default. This PR solves that confusion and also makes it clear that hx-validate must be set to "true".

This change has not been explicitly approved by the maintainers via the issue, hope that's ok. If not, please let me know and I won't make a PR next time until it's approved.

Corresponding issue: #2185

Testing

Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

Copy link
Copy Markdown
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good.

@alexpetros alexpetros merged commit 94ca5f5 into bigskysoftware:master Jan 22, 2024
@MikeMoolenaar MikeMoolenaar deleted the improve-hx-validate-docs branch January 22, 2024 16:45
rekado pushed a commit to rekado/htmx that referenced this pull request Feb 9, 2024
FraserChapman pushed a commit to FraserChapman/htmx that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clarify hx-validate documentation

2 participants