Skip to content

fix sse-swap removal handling in ext/sse.js #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Telroshan merged 1 commit into from
Feb 25, 2024
Merged

fix sse-swap removal handling in ext/sse.js #2247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ext/sse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ This extension adds support for Server Sent Events to htmx. See /www/extensions
// If the body no longer contains the element, remove the listener
if (!api.bodyContains(child)) {
source.removeEventListener(sseEventName, listener);
return;
}

// swap the response into the DOM and trigger a notification
Expand Down
11 changes: 11 additions & 0 deletions test/ext/sse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ describe("sse extension", function() {
var wasClosed = false;
var url;
var mockEventSource = {
_listeners: listeners,
removeEventListener: function(name, l) {
listeners[name] = listeners[name].filter(function(elt, idx, arr) {
if (arr[idx] === l) {
Expand Down Expand Up @@ -149,6 +150,16 @@ describe("sse extension", function() {
this.eventSource.wasClosed().should.equal(true)
})

it('is not listening for events after hx-swap element removed', function() {
var div = make('<div hx-ext="sse" sse-connect="/foo">' +
'<div id="d1" hx-swap="outerHTML" sse-swap="e1">div1</div>' +
'</div>');
this.eventSource._listeners["e1"].should.be.lengthOf(1)
div.removeChild(byId("d1"));
this.eventSource.sendEvent("e1", "Test")
this.eventSource._listeners["e1"].should.be.empty
})

// sse and hx-trigger handlers are distinct
it('is closed after removal with no close and activity, sse-swap', function() {
var div = make('<div hx-get="/test" hx-swap="outerHTML" hx-ext="sse" sse-connect="/foo">' +
Expand Down