Minimize re-rendering of 'bulk update users' table#2249
Merged
alexpetros merged 2 commits intobigskysoftware:masterfrom Feb 1, 2024
Merged
Minimize re-rendering of 'bulk update users' table#2249alexpetros merged 2 commits intobigskysoftware:masterfrom
alexpetros merged 2 commits intobigskysoftware:masterfrom
Conversation
And use ARIA to announce a summary of the bulk update. By using a checkbox input to represent the activation status, we don't need to re-render it when it's changed, because the checkbox itself manages that state. Re: bigskysoftware#1431
Contributor
Author
|
Screenshot 
|
alexpetros
approved these changes
Feb 1, 2024
Collaborator
alexpetros
left a comment
alexpetros
left a comment
There was a problem hiding this comment.
Yup, I like it, thanks @yawaramin !
rekado
pushed a commit
to rekado/htmx
that referenced
this pull request
Feb 9, 2024
* Minimize re-rendering of 'bulk update users' table And use ARIA to announce a summary of the bulk update. By using a checkbox input to represent the activation status, we don't need to re-render it when it's changed, because the checkbox itself manages that state. Re: bigskysoftware#1431 * Improve screen reader pronunciation
FraserChapman
pushed a commit
to FraserChapman/htmx
that referenced
this pull request
Feb 16, 2024
* Minimize re-rendering of 'bulk update users' table And use ARIA to announce a summary of the bulk update. By using a checkbox input to represent the activation status, we don't need to re-render it when it's changed, because the checkbox itself manages that state. Re: bigskysoftware#1431 * Improve screen reader pronunciation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use ARIA to announce a summary of the bulk update. By using a checkbox input to represent the activation status, we don't need to re-render it when it's changed, because the checkbox itself manages that state.
Corresponding issue: #1431
Testing
Tested manually by running Zola locally, verified behaviour works as intended.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded